Fix oder of magnitude reported for current in HA plugin #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the simple MQTT publish service has the same issue: https://github.com/DennisOSRM/hms-mqtt-publisher/blob/main/hms2mqtt/src/simple_mqtt.rs#L43 |
|
This seems to be the correct order of magnitude. Or am I seeing this wrong? |
|
Oh, yes my mistake. Documentation in https://github.com/DennisOSRM/hms-mqtt-publisher/blob/main/hms2mqtt/src/protos/RealData.proto#L29 is wrong then |
|
Once the new release is there I will update the home assistant addon. Thanks for the fix |
|
Oh, good catch! Will amend the PR later today and put out a release in the evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo clippyand fix all issuescargo fmtto format all source filesfixes #85