[Fix] image size before feeding into model #133
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 !
Thx for your great work in monocular depth estimation and the results in my side is quite amazing! 🎉
In this PR：
I fixed the issue with the input model image size.
Previously, the height of the raw image was used for resizing (See), and if the resolution of the raw image is large, the program would run out of memory (OOM).
Also I removed some redundant code from the script.
For
depth_pred, the original script performed a resize to match the resolution ofdepth_predwith that of the raw image (See). This operation has already been implemented in here and here.I would greatly appreciate it if PR could be accepted! Any code suggestions would be appreciated! 😄