Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Shadow Root through css selector #460

Merged

Conversation

dharmesh-hemaram
Copy link
Member

@dharmesh-hemaram dharmesh-hemaram commented Nov 5, 2024

Description

This pull request includes changes to improve element selection within shadow DOMs and simplifies timer initialization logic in the acf-extension application.

Improvements to element selection:

Simplifications to timer initialization:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code (E2E)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (DOCS)
  • I have made corresponding changes to the blog (BLOG)
  • My changes generate no new warnings (SONAR)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Create video on functionality
  • Any dependent changes have been merged and published in downstream modules

@dharmesh-hemaram dharmesh-hemaram merged commit fd27a86 into main Nov 5, 2024
5 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the 413-unable-to-click-element-under-shadow-root branch November 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to click element under Shadow root.
1 participant