Refactor event handling to work on iframe element which don't have src #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…element type checks
Description
This pull request introduces a new utility function
getElementWindow
to standardize how the window object is retrieved for various HTML elements across multiple event handling modules. The most important changes include the addition of this function incommon.events.ts
and its integration into various event modules.Introduction of
getElementWindow
function:libs/acf/events/src/lib/common.events.ts
: AddedgetElementWindow
function to retrieve the window object associated with an element.Integration of
getElementWindow
function:libs/acf/events/src/lib/append.events.ts
: UpdatedcheckNode
function to usegetElementWindow
forHTMLTextAreaElement
andHTMLInputElement
checks.libs/acf/events/src/lib/clipboard.events.ts
: UpdatedgetValue
andcheckNode
functions to usegetElementWindow
for various element type checks. [1] [2]libs/acf/events/src/lib/copy.events.ts
: UpdatedgetValue
function to usegetElementWindow
for various element type checks.libs/acf/events/src/lib/form.events.ts
: UpdateddispatchEvent
,submit
,select
, andclear
functions to usegetElementWindow
for various element type checks. [1] [2] [3]Other changes:
libs/acf/events/src/lib/index.ts
: Removedawait
keyword fromElementEvents.start
call.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: