Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event handling to work on iframe element which don't have src #470

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dharmesh-hemaram
Copy link
Member

…element type checks

Description

This pull request introduces a new utility function getElementWindow to standardize how the window object is retrieved for various HTML elements across multiple event handling modules. The most important changes include the addition of this function in common.events.ts and its integration into various event modules.

Introduction of getElementWindow function:

Integration of getElementWindow function:

Other changes:

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code (E2E)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (DOCS)
  • I have made corresponding changes to the blog (BLOG)
  • My changes generate no new warnings (SONAR)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Create video on functionality
  • Any dependent changes have been merged and published in downstream modules

@dharmesh-hemaram dharmesh-hemaram linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

nx-cloud bot commented Nov 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eabb78b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@dharmesh-hemaram dharmesh-hemaram merged commit 2e829f8 into main Nov 12, 2024
5 of 6 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the 444-iframe-doesnt-work branch November 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iframe doesn't work
1 participant