Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse generate_archive_list to make code more DRY #868

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

siliconfeces
Copy link
Contributor

The "Modify Categories" page was rolling some custom code for listing all archives. This PR changes that to reuse the same function as in "Batch Operations", which has the nice side effect of being faster as well.

@Difegue
Copy link
Owner

Difegue commented Oct 15, 2023

Looks good. In hindsight I'm not quite sure why the categories page still loads the IDs server-side while Batch does an API call, but I'm constantly flip-flopping on which approach is best so might as well keep it like that for now..

I'll need to make yet another "list all archives and checkbox select some" page for tankoubons soon so maybe I'll make up my mind then

@Difegue
Copy link
Owner

Difegue commented Oct 15, 2023

(At least now they both end up using the list code with MULTI so that's good speedwise as mentioned.)

@Difegue Difegue merged commit f60e795 into Difegue:dev Oct 15, 2023
1 check passed
@siliconfeces siliconfeces deleted the faster_modify_categories branch October 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants