fix the issues (#57, #67, #68, #69, #70) #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danglu999
changed the title
danglu999
changed the title
Dimillian
approved these changes
May 28, 2021
|
Thanks! |
danglu999
changed the title
fred-maussion
pushed a commit
to fred-maussion/MovieSwiftUI
that referenced
this pull request
Feb 1, 2024
Dimillian#70) (Dimillian#66) * fix the bug that selected list row remains highlighted * show the indicator of horizontal scrollView * make the width of backdrop image more suitable on small screen size (4.0-inch) * add bottom padding to avoid overlap between image and indicator of scrollview * filter same people and sorted people by their name alphabetically * add filter to avoid loading same data duplicately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #57 that was caused by an issue of the List element, which leads to selected list row remains highlighted
Before:
After:
Fix issue #67 to show indicators of horizontal scrollview.
Before:
After:
Fix issue #68
1 avoid overlap between image and the indicator of scrollview
Before:
After:
2 make the width of backdrop image smaller, then users can identify scroll view easier
Before:
After:
Fix issue #69
Alphabetically sort the popular people by their names
After:
Fix issue #70
A certain page of popular people will be loaded when the Fan Club tab bar appears every time.
Avoiding duplicately loading same data by adding a filter.