Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-76-78: Genre & People Detail Bugs #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glnygl
Copy link

@glnygl glnygl commented Jan 16, 2024

Issue-76: NavigationLink without destination code fixed that issue

Simulator Screen Recording - iPhone 15 Pro - 2024-01-16 at 12 49 59

Issue-78: Remove animations fixed that issue

Simulator Screen Recording - iPhone 15 Pro - 2024-01-17 at 18 29 17

@glnygl glnygl changed the title Issue-76: Fix genre detail pop back bug Issue-76: Fix genre list pop back bug Jan 16, 2024
@glnygl glnygl changed the title Issue-76: Fix genre list pop back bug Issue-76-78: Genre & People Detail Bugs Jan 17, 2024
@Kiyzer
Copy link

Kiyzer commented Feb 4, 2024

Hello everybody,
first of all, congratulations for this really great project..
same issue when you are in the Genres list, you have the list of films according to genre but as soon as you click on a film it returns to the list of films of the Genre.
Same when you are looking for a Film with a comment, as soon as you click on the comment it is not displayed and returns to the FILM detail page.
I hope my descriptions of the bugs isn't confusing and that this hasn't already been covered.
Ogun

@glnygl
Copy link
Author

glnygl commented Feb 4, 2024

Hello everybody, first of all, congratulations for this really great project.. same issue when you are in the Genres list, you have the list of films according to genre but as soon as you click on a film it returns to the list of films of the Genre. Same when you are looking for a Film with a comment, as soon as you click on the comment it is not displayed and returns to the FILM detail page. I hope my descriptions of the bugs isn't confusing and that this hasn't already been covered. Ogun

Hi Ogun, I think I fixed these bugs that you mentioned with this pr. This pop back problem is caused by different navigation code. You can also check this fix in your simulator. If still there is a problem maybe you can add a screetshot of video.

@Kiyzer
Copy link

Kiyzer commented Feb 4, 2024

@glnygl
Hi,
Gülenay,
yes I see your corrections and did . It solved the bugs in Genres Navigations in de Movie details and the cast details but it seems persist when you are in genres List and Review.

RPReplay_Final1707084577.MP4

and the same issue when you tap on Reviews.
I see the same bug when you create a custom list, and you want to check the movie details pop back
Ogün ;)

@glnygl
Copy link
Author

glnygl commented Feb 5, 2024

@glnygl Hi, Gülenay, yes I see your corrections and did . It solved the bugs in Genres Navigations in de Movie details and the cast details but it seems persist when you are in genres List and Review.

RPReplay_Final1707084577.MP4
and the same issue when you tap on Reviews. I see the same bug when you create a custom list, and you want to check the movie details pop back Ogün ;)

Hi Ogun, now i see the problem. Video helped a lot thanks for this. After debug I realized that there is a problem in store. When I comment out "fetchMovieDetails" func in MovieDetail view it works properly. But i didn't understand why dispatch func cause this problem. Im still on it. If you find a way to solve this bug please inform me. Im really curious about it. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants