Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proposal For /info Endpoint and Config Options #85

Merged
merged 8 commits into from
Feb 27, 2024
Merged

Conversation

ntindle
Copy link

@ntindle ntindle commented Dec 11, 2023

Pull Request

Description

Please provide a brief description of your pull request. Include any relevant context, such as the issue it addresses or the feature it introduces.

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

Additional Notes

If there are any additional details or considerations that reviewers should be aware of, please provide them here.

References, Fixes and Closes

List any other pull requests or issues that this pull request references, fixes, or closes, if applicable.

@ntindle ntindle changed the title Add Proposal For /info Endpoint Add Proposal For /info Endpoint and Config Options Dec 11, 2023
Co-authored-by: J. Zane Cook <jzanecook@users.noreply.github.com>
@ntindle
Copy link
Author

ntindle commented Dec 12, 2023

Create a separate endpoint for supported versions. /ap/version -> ['1','2','3']

Make sure the /info endpoint has the latest protocol version supported. /ap/v2/agent/info and /ap/v3/agent/info

Co-authored-by: J. Zane Cook <jzanecook@users.noreply.github.com>
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
agentprotocolai ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 7:43pm

Co-authored-by: J. Zane Cook <jzanecook@users.noreply.github.com>

## Summary

We would like to add support for `config_options` to relace most usages of `addtional_input` so that we can provide clear and structured configrations to our agents. This will fix the "unknown unknowns" problem that exsits with many agents today of not knowing what the valid additional inputs are for a given representation of an agent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be clear that the config_options is done to specify the schema of additional_input

@ntindle ntindle marked this pull request as ready for review February 13, 2024 19:01
@jzanecook jzanecook changed the base branch from main to v2 February 27, 2024 19:45
@jzanecook jzanecook merged commit 89a5310 into Div99:v2 Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants