-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First working version to implement argparse-manpage #192
Conversation
I added a simple test (1ab2168) for the generated manpages, but I struggle to find the right path to the manpage files (I added a stub, hence the failed tests). Perhaps you know how to set this correctly? And if you'd like to add more upstream manpage tests of your own (checking whatever Fedora likes to have), this is the place to put them :-) |
Ok, I patched it using |
Mhhh, my patch only works on Linux... |
The The prefix |
On Fedora Linux, I started testing by checking out the current
So I tried adding
Switching to the When I do
I get the following man pages in
I spot-checked a couple with e.g. I tried again, installing the package as a regular wheel instead of an editable one:
This time the man pages were installed in Overall, I would say this passes basic “smoke tests” on Fedora Linux. I haven’t done any of the following:
That’s all the time I expect to spend on this today, though. Hope it helped. |
That's not very important, because pypet2bids is part of the PET plugin, which is still a bit experimental / under development (it's probably something trivial that it hasn't been tested for v3.11)
That seems like a dcm2niix issue, not a BIDScoin issue...?
Looks like my refactoring/clean-up for this new branch worked out well :-). I'll go ahead and merge it to master, further development/PR's can be merged from there
Just let me know if you run into issues or have any news
Can't blame you, thanks and enjoy your weekend :-) |
What's roughly speaking the time frame you have in mind for shipping BIDScoin? I think it is currently in pretty good shape, so I could brew a release for you when needed. (p.s. I am away from July 20 - August 10, so no release in that period) |
It’s hard to say. It depends on my free time for packaging it (including packaging some of the most desirable optional dependencies, and their dependencies), and on how much time other Fedora contributors have to do new-package reviews. I’ve taken it on as a low-priority project: I do intend to see it through, but I’m not in a big hurry. I would be perfectly happy to spend the next month lining up dependencies. I also have the flexibility to ship (compatible) updates after the initial package, backport selected changes as patches if needed, package a snapshot if there’s a really good reason to do so, etc., so a new release before the initial package is nice to have, but not strictly required. |
I think I cannot invite @musicinmybrain here for review, but when you are up to it, can you have a look and see if this works for you? Any feedback is more than welcome :-)