test: add test coverage

.gitignore

@@ -7,6 +7,7 @@
 *.dylib
 bin
 testbin/*
+manager
 
 # Test binary, build with `go test -c`
 *.test

Makefile

@@ -75,7 +75,7 @@ build: generate fmt vet tidy ## Build manager binary.
 
 .PHONY: run
 run: manifests generate fmt vet tidy ## Run a controller from your host.
-	go run ./main.go
+	go run ./main.go --log-level=debug
 
 # Find or download gen-crd-api-reference-docs
 GEN_CRD_API_REFERENCE_DOCS = $(GOBIN)/gen-crd-api-reference-docs

README.md

@@ -25,6 +25,8 @@ rely on.
 If no pods are running matching either `app: backend` or `app: another-rds-client` the aws instance named `rds-myname` will be terminated after
 a grace period of 5 minutes.
 
+**Note**: If no grace period is set the instance will be terminated immediately after the condition ScaledToZero is set to `True`.
+
 ```yaml
 kind: AWSRDSInstance
 metadata:
@@ -88,7 +90,9 @@ type: Opaque
 
 Each resource reports various conditions in `.status.condtions` which will give the necessary insight about the 
 current state of the resource.
-Namely there are three conditions which are `Ready`, `Reconciling` and `PodsReady`.
+Namely there are the conditions `Ready` and `ScaledToZero`.
+ScaledToZero will give insigh whether the target rules have pods elected as up or down and Ready gives insight about
+the reconcililation status itself.
 
 ```yaml
 status:
@@ -99,12 +103,12 @@ status:
     reason: ReconciliationFailed
     status: "False"
     type: Ready
-  - lastTransitionTime: "2023-11-24T09:46:42Z"
-    message: ""
-    observedGeneration: 32
-    reason: Progressing
-    status: "True"
-    type: Reconciling
+  - lastTransitionTime: "2023-12-11T14:03:31Z"
+    message: selector matches at least one running pod
+    observedGeneration: 3
+    reason: PodsRunning
+    status: "False"
+    type: ScaledToZero
 ```
 
 ## Installation

api/v1beta1/awsrdsinstance_types.go

@@ -15,10 +15,13 @@ type AWSRDSInstance struct {
 }
 
 type AWSRDSInstanceSpec struct {
-	Options      `json:",inline"`
-	Secret       LocalObjectReference `json:"localObkjectReference,omitempty"`
-	Region       string               `json:"region,omitempty"`
-	InstanceName string               `json:"instanceName,omitempty"`
+	Suspend      bool                   `json:"suspend,omitempty"`
+	ScaleToZero  []metav1.LabelSelector `json:"scaleToZero,omitempty"`
+	GracePeriod  metav1.Duration        `json:"gracePeriod,omitempty"`
+	Interval     metav1.Duration        `json:"interval,omitempty"`
+	Secret       LocalObjectReference   `json:"secret,omitempty"`
+	Region       string                 `json:"region,omitempty"`
+	InstanceName string                 `json:"instanceName,omitempty"`
 }
 
 // KeycloakClusterList contains a list of KeycloakCluster.
@@ -51,6 +54,11 @@ func AWSRDSInstanceReady(set AWSRDSInstance, status metav1.ConditionStatus, reas
 	return set
 }
 
+func AWSRDSInstanceScaledToZero(set AWSRDSInstance, status metav1.ConditionStatus, reason, message string) AWSRDSInstance {
+	setResourceCondition(&set, ConditionScaledToZero, status, reason, message, set.ObjectMeta.Generation)
+	return set
+}
+
 // GetStatusConditions returns a pointer to the Status.Conditions slice
 func (in *AWSRDSInstance) GetStatusConditions() *[]metav1.Condition {
 	return &in.Status.Conditions

api/v1beta1/mongodbatlascluster_types.go

@@ -15,10 +15,13 @@ type MongoDBAtlasCluster struct {
 }
 
 type MongoDBAtlasClusterSpec struct {
-	Options     `json:",inline"`
-	GroupID     string               `json:"groupID,omitempty"`
-	Secret      LocalObjectReference `json:"localObkjectReference,omitempty"`
-	ClusterName string               `json:"clusterName,omitempty"`
+	Suspend     bool                   `json:"suspend,omitempty"`
+	ScaleToZero []metav1.LabelSelector `json:"scaleToZero,omitempty"`
+	GracePeriod metav1.Duration        `json:"gracePeriod,omitempty"`
+	Interval    metav1.Duration        `json:"interval,omitempty"`
+	GroupID     string                 `json:"groupID,omitempty"`
+	Secret      LocalObjectReference   `json:"secret,omitempty"`
+	ClusterName string                 `json:"clusterName,omitempty"`
 }
 
 // KeycloakClusterList contains a list of KeycloakCluster.
@@ -51,6 +54,11 @@ func MongoDBAtlasClusterReady(set MongoDBAtlasCluster, status metav1.ConditionSt
 	return set
 }
 
+func MongoDBAtlasClusterScaledToZero(set MongoDBAtlasCluster, status metav1.ConditionStatus, reason, message string) MongoDBAtlasCluster {
+	setResourceCondition(&set, ConditionScaledToZero, status, reason, message, set.ObjectMeta.Generation)
+	return set
+}
+
 // GetStatusConditions returns a pointer to the Status.Conditions slice
 func (in *MongoDBAtlasCluster) GetStatusConditions() *[]metav1.Condition {
 	return &in.Status.Conditions

api/v1beta1/types.go

@@ -5,22 +5,15 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-type Options struct {
-	Suspend     bool                   `json:"suspend,omitempty"`
-	ScaleToZero []metav1.LabelSelector `json:"scaleToZero,omitempty"`
-	GracePeriod metav1.Duration        `json:"gracePeriod,omitempty"`
-	Interval    metav1.Duration        `json:"interval,omitempty"`
-}
-
 type LocalObjectReference struct {
 	Name string `json:"name,omitempty"`
 }
 
 const (
-	Finalizer            = "finalizers.doodle.com"
-	ConditionReady       = "Ready"
-	ConditionReconciling = "Reconciling"
-	ConditionPodsReady   = "PodsReady"
+	Finalizer             = "finalizers.doodle.com"
+	ConditionReady        = "Ready"
+	ConditionReconciling  = "Reconciling"
+	ConditionScaledToZero = "ScaledToZero"
 )
 
 // ConditionalResource is a resource with conditions

chart/cloud-autoscale-controller/crds/cloudautoscale.infra.doodle.com_awsrdsinstances.yaml

@@ -38,11 +38,6 @@ spec:
                 type: string
               interval:
                 type: string
-              localObkjectReference:
-                properties:
-                  name:
-                    type: string
-                type: object
               region:
                 type: string
               scaleToZero:
@@ -95,6 +90,11 @@ spec:
                   type: object
                   x-kubernetes-map-type: atomic
                 type: array
+              secret:
+                properties:
+                  name:
+                    type: string
+                type: object
               suspend:
                 type: boolean
             type: object

chart/cloud-autoscale-controller/crds/cloudautoscale.infra.doodle.com_mongodbatlasclusters.yaml

@@ -40,11 +40,6 @@ spec:
                 type: string
               interval:
                 type: string
-              localObkjectReference:
-                properties:
-                  name:
-                    type: string
-                type: object
               scaleToZero:
                 items:
                   description: A label selector is a label query over a set of resources.
@@ -95,6 +90,11 @@ spec:
                   type: object
                   x-kubernetes-map-type: atomic
                 type: array
+              secret:
+                properties:
+                  name:
+                    type: string
+                type: object
               suspend:
                 type: boolean
             type: object