Fix error when accessing status of empty newChats array #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc6ffd3:
|
…ccessing_last_chat_status
YyumeiZhang
reviewed
Dec 6, 2024
| if (oldChats.length === 0 || newLastChat.id !== oldLastChat.id) { | ||
| shouldScroll = true; | ||
| } | ||
| } else if (newChats.length === oldChats.length && newChats.length > 0) { |
There was a problem hiding this comment.
我理解改动的区别如下
。
我理解两者的效果是一致的？
或者可以提供一个复现的 demo 展示下修改前后的区别吗？
There was a problem hiding this comment.
Sorry I'm using version 2.68.4, it looks like this issue has been fixed in the new version, it was an oversight on my part not to notice, I'll switch off this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
This PR fixes a bug where an error occurs when accessing the status property of the last chat in newChats array when the array is empty. The fix adds a check to ensure newChats array is not empty before accessing the status property.
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information