Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ArrayField): enhance add method to support optional index-based insertion issue#2544 #2628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shabi-x
Copy link
Contributor

@Shabi-x Shabi-x commented Dec 12, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese
-feat: 根据 issue#2544的建议,针对arrayfiled组件add只能始终添加到最后一个位置,我阅读代码后修改了一下add方法,提供了一个可选的index来给与使用者添加新项位置的可选性,并添加了一个storybook测试项进行了一些测试。


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@Shabi-x
Copy link
Contributor Author

Shabi-x commented Dec 12, 2024

在做一些开源的尝试,有不足之处或我的修改有需要进一步考虑的空间欢迎批评指正,谢谢!

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e5319d:

Sandbox Source
pr-story Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant