fix: render state value in children render always get init one #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38e9448:
|
YannLynn
requested review from
YyumeiZhang
and removed request for
pointhalo
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
fix-2633
|
| Run status |
|
| Run duration | 07m 48s |
| Commit |
|
| Committer | YannLynn |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
277
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
YyumeiZhang
approved these changes
Dec 16, 2024
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 07m 51s |
| Commit |
|
| Committer | YannLynn |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
11
|
|
Skipped
|
0
|
|
Passing
|
277
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #2633
之前的写法将 children 放在 state 中维护，仅在 key 值改变的时候更新 children，导致在 children 渲染 state （如 currentIndex 值）仅能得到一开始的初始值。
修复后 children 根据当前 props 生成，在 children 渲染 state 值能够正确更新。
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information