Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The display of disabled subNavItem in vertical Navigation is not as expected when it is collapsed #2637

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

YannLynn
Copy link
Collaborator

@YannLynn YannLynn commented Dec 16, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2636
修改前 Tooltip 包裹元素不是一个 valid children 命中 wrapSpan 逻辑,导致 disabled 项目并排展示,加一个 span 包裹保证元素为 valid children

Changelog

🇨🇳 Chinese

  • Fix: 修复竖向 Navigation 在收起状态下 disabled subNavItem 展示不符合预期问题

🇺🇸 English

  • Fix: fixed the issue that the display of disabled subNavItem in vertical Navigation does not meet expectations when it is collapsed

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YannLynn YannLynn requested a review from pointhalo December 16, 2024 12:02
Copy link

codesandbox-ci bot commented Dec 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76cb7bf:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Dec 16, 2024

semi-design    Run #3028

Run Properties:  status check passed Passed #3028  •  git commit 8a7cecff77 ℹ️: Merge 76cb7bfefa2635ce63ed0678437123154f4230ab into 2c43674a3124716d80b213e87a84...
Project semi-design
Branch Review fix-2636
Run status status check passed Passed #3028
Run duration 07m 46s
Commit git commit 8a7cecff77 ℹ️: Merge 76cb7bfefa2635ce63ed0678437123154f4230ab into 2c43674a3124716d80b213e87a84...
Committer YannLynn
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit c93c005 into main Dec 16, 2024
5 of 6 checks passed
@pointhalo pointhalo deleted the fix-2636 branch December 16, 2024 12:52
Copy link

cypress bot commented Dec 16, 2024

semi-design    Run #3029

Run Properties:  status check passed Passed #3029  •  git commit c93c00548c: fix: The display of disabled subNavItem in vertical Navigation is not as expecte...
Project semi-design
Branch Review main
Run status status check passed Passed #3029
Run duration 07m 58s
Commit git commit c93c00548c: fix: The display of disabled subNavItem in vertical Navigation is not as expecte...
Committer YannLynn
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] 竖向 Navigation 在收起状态下 disabled subNavItem 展示不符合预期
2 participants