Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty large change, though mostly just reorganization of existing code;
-
quirks.PrefixPesterQuirk
quirks.SuffixPesterQuirk
quirks.ReplacePesterQuirk
quirks.RegexpPesterQuirk
quirks.RandomPesterQuirk
quirks.MispellerPesterQuirk
quirks.PesterQuirkFactory
to replace the originaldataobjs.pesterQuirk
constructor. It returns the appropriate object for the given dict's"type"
valuedataobjs.pesterQuirks
intoquirks.PesterQuirkCollection
quirks.ScriptQuirks
intopyquirks.ScriptQuirks
to resolve a newly created circular dependency & move the 2 script quirk classes into the same fileThis is a somewhat risky move. i've confirmed that quirks run as expected for each type but this was not a super in depth test or anything, just added one of each & used the quirk tester. No logic outside of these classes has been changed though, calls to the original
dataobj.pesterQuirk
were changed to callquirks.PesterQuirkFactory
instead which offers an identical interface.should make the code much easier to maintain & extend