Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix Jass Parser converting -2147483648 to --2147483648 #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

speige
Copy link
Contributor

@speige speige commented Dec 17, 2024

No description provided.

@speige speige force-pushed the ParserUnaryMinusOverflow branch from feb2d1a to 766b719 Compare December 17, 2024 16:42
@Drake53
Copy link
Owner

Drake53 commented Dec 19, 2024

Thanks for the bugfix PR, but the JASS library implementation in the master branch is kind of deprecated, because I made a new implementation on the vjass branch (which I basically use as a development branch at the moment). The new implementation does not attempt to evaluate the value of the expression so it does not have this issue.

The new implementation is closer to roslyn/C# syntax, and it supports trivia so you can make changes to the syntax tree without losing whitespace information. Obviously this is a breaking change and I never got around to rewriting all the code which depends on the JASS library (including the decompiler project which I see you also made a PR for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants