Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rod of Souls XP doesn't seem to be applying #93

Open
SCPRedMage opened this issue Apr 5, 2023 · 0 comments
Open

Rod of Souls XP doesn't seem to be applying #93

SCPRedMage opened this issue Apr 5, 2023 · 0 comments

Comments

@SCPRedMage
Copy link

I've noticed when using a Rod of Souls, I'm routinely notified that I'm picking up 1-5 XP orbs, when in theory it should be a minimum of 6 (1 + the bonus 5).

Looking at both the use function in ExtendedFishingRodItem.java and the modifyBobber function in FishingRodPropertyMixin.java, I'm seeing it set "bonusExperience" to 0, then add bonus.getBaseExperience() from any FishingBonus items in the player's inventory, and then finally set the XP with "gf_setBaseExperience(1 + bonusExperience)". Since ExtendedFishingRodItems don't implement FishingBonus, I'm not seeing any place where the rod's own experience variable would be added.

@SCPRedMage SCPRedMage mentioned this issue Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant