-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding macOS support via Docker #27
base: master
Are you sure you want to change the base?
Conversation
awesome addition thanks 👍 |
It works on Linux 👍 (But i wouldnt privileged the container in the compose-file) |
it works (tested in MacOs but should work everywhere), please merge it |
@pablobuenaposada commits have been squashed as requested. |
@miathedev on MacOS I get a bunch of errors when I invoke docker-compose without
|
it's a shame nothing gets merged 😢 |
All good I still have hope @pablobuenaposada. No merge conflicts yet 😜 |
probably a rebase would help? |
I dunno, I'm not a git expert but I've kind of stopped using rebase because it messes with the history. If rebasing would help get this merged I'm wiling to do it. |
You can put your commit on top with |
You don't need to rebase it. I just have not had time to get to this particular issue and test it. It's next on my list for the project though! |
I think not rebasing is a silly move, you would test it with old code, would work, and you will merge it giving the chance that the new commits mess up the dockerization and having a broken master branch until someone tells you about 🤷♂ This is the perfect scenario to do a rebase, nothing will conflict so it's a no brainer. |
I would merge in master before I start testing, don't worry about that ;) |
well, here you have the first conflict, then can we rebase now? |
@pablobuenaposada @Drewsif I resolved the merge conflict. |
Hey @deepeeess @miathedev @pablobuenaposada you can use PiShrink dockerized | Docker Hub PiShrink: macOS Setup
cd ~/Directory-with-RPi-image
docker run --privileged=true --rm \
--volume $(pwd):/workdir \
monsieurborges/pishrink \
pishrink -Zv IMAGE_NAME.img NEW-IMAGE_NAME.img |
Didnt expect that this issue still exist after this time! @Drewsif what speaks against a merge? |
I don't get it honestly, other people are starting to create their own repos with this project dockerized because this is getting postponed again and again. |
ping @Drewsif! Is it possible to merge this? |
This will allow you to run PiShrink on macOS with a Docker engine installed. I think this will also work on Linux but I haven't tested it.