Updates for .NET8 Preview 7 #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because of changes in the token handler
The new version of wilson deserializes the claims differently. This commit changes the DPoP's use of the jwk claim and adds a test that we still handle complex subclaims (arrays for key_ops)
The new wilson version's limitation when reading a complex Header and Payload value into a dictionary is that it requires that you specify the concrete Dictionary type rather than the IDictionary interface. Thus, we can go back to the original way of reading the jwk, and then serializing it into json to pass to the JsonWebKey ctor, we just need to use Dictionary instead of IDictionary when retrieving the header.
The test in question creates a proof token, and now creates the jwk parameters as a Dictionary<string, object> rather than an anonymous type which is then serialized by System.Text.Json. In the new wilson version, claims can be passed as dictionaries, but not as anonymous types.
|
Also, @josephdecock, take note of the warnings about obsolete APIs that are being used. We should find the new/replacement APIs and use those now instead. |
ValidateToken has been deprecated
JWTs are already representing the jwk claim as a JsonElement, and we don't need additional conversions
AddAsync is only needed for value generators that need async database access (e.g., HiLoValueGenerator), and we don't use those generators
Code analysis points out that that throws if the header is already set. In this situation, multiple www-authenticate headers would be nonsense, so we explicitly throw if that happens.
|
All the warnings are now resolved as well.
|
brockallen
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...maybe we want to wait for preview 8. As expected the JWT handler has some regressions (e.g. "sub claim is missing").