-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIBA Customization Extensibility Points #1497
Conversation
This PR began as #1361, but that PR didn't get merged for a long time, so I rebased it and created a new PR here. @gislikonrad - thanks for raising this issue and submitting the PR back in the summer! Do you think this new approach will meet your needs? |
Two thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would work for us at our organization. I just had some comments on the naming of the new properties in the backchannel authentication models and contexts.
src/IdentityServer/Validation/Models/ValidatedBackchannelAuthenticationRequest.cs
Outdated
Show resolved
Hide resolved
Result -> ValidationResult makes the code clearer and avoids an awkward Result.Result construction
This is a dependency on an internal class that is never used
- Custom validators are invoked - Custom input can be processed in custom validators - Complex properties in the custom properties are flattened into the JSON of the response to the client - Custom properties are passed to the login notification service
This adds extensibility points to CIBA to allow for custom request and response parameters.
AddCustomAuthorizeRequestValidator
andAddCustomTokenRequestValidator