-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-8045: Fix hanged node search when the user types faster than search #15733
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8045
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I would like to know what @QilongTang thinks about it.
Failed on test |
@QilongTang this seems to overlap with #15726 am I getting that right? How do you want to proceed with these two prs? |
@QilongTang after taking a look at this I think I prefer the approach in #15726 - it's behind a feature flag, has tests, avoids locks, and I think is more idiomatic. I don't know if it solves the issue of the hanging search though - @bendikberg can you verify if it fixes this issue? |
Improvements in last commit:
|
UI Smoke TestsTest: success. 11 passed, 0 failed. |
Added unit tests for debouncing. |
Purpose
Currently the node search hangs when the user types faster than the time it takes Lucene to provide results because it is searching in the main UI thread. This PR provides a debouncing algorithm and performs searches sequentially outside of the main UI thread for a smoother search experience. Currently there is no support for cancelling previous search tasks in lucenenet so this is a fix around that limitation
Before fix:
After fix:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Prevent node search from hanging during fast typing.
Reviewers
@RobertGlobant20
@QilongTang
@sm6srw
FYIs
@avidit