i#6466: Fix raw2trace missing encoding error for filtered traces #6465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a corner case for filtered traces in the raw2trace delayed branch logic that affected how encodings were written. Adds a missing increment of the ordinal into the decode_pcs array for zero sized instr entries, since the decode_pcs include such instrs too. Adds a raw2trace_unit_test for filtered traces.
abhinav92003
changed the title
|
x86-32 failures are #6417. |
abhinav92003
commented
Nov 19, 2023
derekbruening
approved these changes
Nov 19, 2023
|
x86-32 failures are #6417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a corner case for filtered traces in the raw2trace delayed branch logic
that affects how encodings are written.
Adds an increment missing for zero sized pc entries for the ordinal into the
decode_pcs array. This caused the wrong decode_pc to be recorded as
emitted, which caused the "missing encoding" error when that decode_pc
was not really emitted later.
This affects CTI that read memory and may generate in some cases only a
zero-sized PC entry (if the instr is i-filtered out but its memref isn't).
Adds a raw2trace_unit_test for filtered traces that fails without this fix.
Fixes: #6466