Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trade.py and updated constants.py #27

Closed
wants to merge 2 commits into from

Conversation

rickecon
Copy link
Collaborator

  • make format and make documentation has been run. (You may also want to run make test.)

This PR starts adding trade to OG-PHL.

  • Adds trade.py
  • Updated constants.py

cc: @jdebacker @SeaCelo

@SeaCelo
Copy link
Collaborator

SeaCelo commented Oct 22, 2024

Hi @rickecon

Thank you for your work on this PR. It seems that the content appears more like a placeholder rather than a complete and documented solution. Documentation would help us understand the purpose of the changes.

Could you please provide more detailed documentation and ensure that all relevant information is included? This will help us better evaluate the PR and understand its intended use.

also, please remember to make format and the other steps.

Looking forward to your updates.

@SeaCelo
Copy link
Collaborator

SeaCelo commented Oct 22, 2024

Let's try this PR again with the full documentation. Closing

@SeaCelo SeaCelo closed this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (9201542) to head (74ec833).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ogphl/trade.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   70.54%   68.79%   -1.76%     
==========================================
  Files          12       13       +1     
  Lines         275      282       +7     
==========================================
  Hits          194      194              
- Misses         81       88       +7     
Flag Coverage Δ
unittests 68.79% <0.00%> (-1.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon rickecon deleted the trade branch October 22, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants