-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use skills #1
Open
ilonasu
wants to merge
33
commits into
master
Choose a base branch
from
17.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use skills #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to set permissions. Private custom fields are removed from notifications to non-users.
…n elements change a) Horde mailer code seems not to work in shutdown callbacks when the link notifications run under FPM (#26997) b) PM notifications should only be done on direct changes in the project and not updates caused by elements
…ignored elementes Reverted all pe_status setting from datasource, as its only purpose is ACL on elements and marking new elements. It has no relationship to datasource status or information that an element is deleted.
… definition-specific values
… definition-specific values Do export too, for consistency
… definition-specific values Do export too, for consistency
… definition-specific values Do export too, for consistency
…gs to allow eg. group-specific IDs
…bers where group members inconsistently get access
Hi ilonasu, thanks for contributing to EGroupware :) Somethings wrong with your pull request :( Please base it on master, as this is where our development happens. For non-trivial fixes or new features, please explain what it is supposed to do and what the use-cases for that feature are. Ralf |
Maybe it's easier to open a new pull-request and close that one ... |
…straint between element & milestone
ralfbecker
added a commit
that referenced
this pull request
Oct 6, 2021
…, null given guarding key() from calling with null eg. $button = key($content['button']) --> key($content['button'] ?? []) or check before !empty($content['button'])
ralfbecker
added a commit
that referenced
this pull request
Oct 6, 2021
…, null given guarding key() from calling with null eg. $button = key($content['button']) --> key($content['button'] ?? []) or check before !empty($content['button'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May i add skills to project and than use it in other modules? When user increase skill type - user auto accessing next data level.