Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iris pin #2026

Closed
wants to merge 4 commits into from
Closed

Update iris pin #2026

wants to merge 4 commits into from

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 15, 2023

Description

iris=3.5 is out and has a bunch of nice features and bugfixes; I think we should update our pin


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added installation Installation problem iris Related to the Iris package labels May 15, 2023
@valeriupredoi valeriupredoi added this to the v2.9.0 milestone May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2026 (2e091d2) into main (be534fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2026   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         236      236           
  Lines       12464    12464           
=======================================
  Hits        11565    11565           
  Misses        899      899           

@remi-kazeroni
Copy link
Contributor

@valeriupredoi, what about waiting for iris 3.6.0 scheduled for Wednesday? And would such change of pin require a new release as for Python3.11?

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented May 15, 2023

hmm I was thinking we'd pin on 3.5 and obv can grab 3.6 once it's out - my idea was to grab the various bugfixes from 3.5. No need to release anything, just yet - this would be used only by the dev installations, and also for release testing (if we don't release a bugfix release after we'd merge this) 👍

@bouweandela
Copy link
Member

@valeriupredoi I understand that this solves a few problems, but doesn't the tool run more or less fine with iris v3.4? Anyone doing a new installation will already get 3.5, so this would just stop people who want to upgrade an older environment from doing that.

And would such change of pin require a new release as for Python3.11?

Lower bounds on packages generally do not cause as much trouble as upper bounds. The Python 3.11 thing happens because we had an upper bound on a dependency in the last release. Because only recent versions of that dependency package support Python 3.11, this upper bound rules out all versions of that package on conda-forge that support Python 3.11.

@valeriupredoi
Copy link
Contributor Author

@bouweandela they already have to upgrade quite a few bits in the env from the changes we made in the pins for supporting Python 3.11. I reckon we can slip this one through too. I am not ready to give up my dog for this so if you guys consider it unnecessary, am OK to close, but I do like my updated deps 😁

@valeriupredoi
Copy link
Contributor Author

Because only recent versions of that dependency package support Python 3.11, this upper bound rules out all versions of that package on conda-forge that support Python 3.11.

Indeed. It's actually a combination of releasing the upper bound on esmpy (was <8.4) and placing a lower bound on prospector (now >=1.9, the only one that supports Py311)

@remi-kazeroni
Copy link
Contributor

@valeriupredoi - is this still needed because the Dask distributed PR (#2049) put an lower pin to iris>3.6.0?

@valeriupredoi
Copy link
Contributor Author

nope, well pointed out @remi-kazeroni 🍺 Ah, evolution 🐒

@valeriupredoi valeriupredoi deleted the update_iris_pin branch June 1, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants