-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy area weights #2354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
=======================================
Coverage 94.29% 94.30%
=======================================
Files 246 246
Lines 13540 13549 +9
=======================================
+ Hits 12768 12777 +9
Misses 772 772 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
do we still need this in light of the new iris 3.9.0? If so, just say "duck" and I'll merge it 🦆 |
🦆 |
(the new feature is unfortunately not included in iris 3.9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a 🦆 's been asked for!
Description
This is a simple workaround for lazy area weights until SciTools/iris#5658 is available.
Related to #674
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: