Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of std::advance with endpoint checking #47

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

The9Cat
Copy link
Contributor

@The9Cat The9Cat commented Sep 29, 2023

The OpenMP parallel loop is implemented with a strided iterator. This change manually ensures that the initial iterator position is not advanced beyond end().

@michael-petersen michael-petersen merged commit 1d9e8bc into main Sep 29, 2023
0 of 8 checks passed
@michael-petersen
Copy link
Member

This works as expected and doesn't seem to cause any harm (other than looking a little more clunky). So I'll merge it in.

@The9Cat The9Cat deleted the FixIteratorAdvance branch October 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants