Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search cache #304

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix search cache #304

wants to merge 3 commits into from

Conversation

yCobanoglu
Copy link
Member

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 20, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.72%.

Quality metrics Before After Change
Complexity 0.43 ⭐ 0.50 ⭐ 0.07 👎
Method Length 69.20 🙂 73.33 🙂 4.13 👎
Working memory 8.08 🙂 8.09 🙂 0.01 👎
Quality 74.25% 🙂 73.53% 🙂 -0.72% 👎
Other metrics Before After Change
Lines 585 620 35
Changed files Quality Before Quality After Quality Change
ebl/corpus/web/bootstrap.py 43.22% 😞 43.08% 😞 -0.14% 👎
ebl/corpus/web/texts.py 87.61% ⭐ 79.20% ⭐ -8.41% 👎
ebl/fragmentarium/web/fragment_search.py 80.17% ⭐ 80.15% ⭐ -0.02% 👎
ebl/tests/corpus/test_texts_route.py 84.64% ⭐ 84.15% ⭐ -0.49% 👎
ebl/tests/fragmentarium/test_fragments_search_route.py 77.38% ⭐ 77.29% ⭐ -0.09% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ebl/corpus/web/bootstrap.py create_corpus_routes 0 ⭐ 262 ⛔ 19 ⛔ 43.08% 😞 Try splitting into smaller methods. Extract out complex expressions
ebl/tests/fragmentarium/test_fragments_search_route.py test_search_fragmentarium_combined_query 1 ⭐ 189 😞 10 😞 58.27% 🙂 Try splitting into smaller methods. Extract out complex expressions
ebl/tests/fragmentarium/test_fragments_search_route.py test_search_fragmentarium_references 0 ⭐ 169 😞 9 🙂 63.08% 🙂 Try splitting into smaller methods
ebl/fragmentarium/web/fragment_search.py FragmentSearch.__init__ 0 ⭐ 164 😞 67.65% 🙂 Try splitting into smaller methods
ebl/tests/fragmentarium/test_fragments_search_route.py test_search_fragmentarium_transliteration 2 ⭐ 121 😞 8 🙂 68.53% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codeclimate
Copy link

codeclimate bot commented Oct 21, 2022

Code Climate has analyzed commit 4e88e35 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 91.3% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.2% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant