Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.6 #109

Merged
merged 16 commits into from
Oct 20, 2024
Merged

1.20.6 #109

merged 16 commits into from
Oct 20, 2024

Conversation

zml2008
Copy link
Collaborator

@zml2008 zml2008 commented Apr 19, 2024

For merging when final release happens

@zml2008 zml2008 self-assigned this Apr 19, 2024
@zml2008 zml2008 added the enhancement New feature or request label Apr 24, 2024
@aurorasmiles aurorasmiles mentioned this pull request May 8, 2024
Merged
@zml2008 zml2008 mentioned this pull request May 20, 2024
Closed
@zml2008 zml2008 changed the title 1.20.5 1.20.6 May 30, 2024
@DaddyRobLIVE

This comment was marked as spam.

Sign in to view
@CyberFlameGO
Copy link

I know the above comment was marked as spam but to address it - the PR's checks are caching the built mod artifact which you can use, and I've personally found no issues with this PR's builds if that's any help to you @DaddyRobLIVE :) Try the artifact here: https://github.com/EngineHub/WorldEditCUI/actions/runs/9539790119/artifacts/1606652226

@me4502
Copy link
Member

me4502 commented Jun 18, 2024

The problem is that due to Fabric API changes, this cannot be run alongside WorldEdit, which is a majority of its use case. A workaround for the Fabric API issue is necessary before it can be properly released

@CyberFlameGO
Copy link

Ohh I'm assuming that's what #113 aims to achieve? That's my bad though 😭 I've only used it in conjunction with server-side WorldEdit

@luavixen
Copy link

I wanted to use WorldEditCUI on 1.21, so I updated the https://github.com/EngineHub/WorldEditCUI/tree/mc/1.20.5 branch to 1.21 in this commit on my fork: luavixen@b6e3cf9

Extremely minimal changes are required, and I would be happy to open a pull request or something else, but I don't want to interrupt your work.

@Ka1nnn
Copy link

Ka1nnn commented Jul 1, 2024

I wanted to use WorldEditCUI on 1.21, so I updated the https://github.com/EngineHub/WorldEditCUI/tree/mc/1.20.5 branch to 1.21 in this commit on my fork: luavixen@b6e3cf9

Extremely minimal changes are required, and I would be happy to open a pull request or something else, but I don't want to interrupt your work.

this did not want to build for me it gave me this error

image

@Phoenix616
Copy link

I wanted to use WorldEditCUI on 1.21, so I updated the mc/1.20.5 branch to 1.21 in this commit on my fork: luavixen@b6e3cf9
Extremely minimal changes are required, and I would be happy to open a pull request or something else, but I don't want to interrupt your work.

this did not want to build for me it gave me this error

Worked fine for me: WorldEditCUI-1.21+01-SNAPSHOT-cleaned.jar.zip, only weird thing is that it included the fabric dependency jars when running the build task. (I removed them manually from that jar)

@DaddyRobLIVE
Copy link

Can I please have 1.20.6 working dev build?

@EngineHub EngineHub locked as off-topic and limited conversation to collaborators Jul 8, 2024
@zml2008 zml2008 added this to the 1.20.6+01 milestone Oct 20, 2024
@zml2008 zml2008 merged commit 2e533c5 into master Oct 20, 2024
4 checks passed
@zml2008 zml2008 deleted the mc/1.20.5 branch October 20, 2024 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CyberFlameGO CyberFlameGO CyberFlameGO approved these changes

@aurorasmiles aurorasmiles aurorasmiles approved these changes

Assignees

@zml2008 zml2008

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.20.6+01
Development

Successfully merging this pull request may close these issues.
8 participants
@zml2008 @DaddyRobLIVE @CyberFlameGO @me4502 @luavixen @Ka1nnn @Phoenix616 @aurorasmiles