Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
functions.js
. These comments are basically copied from myfunctions.js
functions.js
, to make them clearer and possibly more performant. E.g.getPreferredItemInTag
is rewritten to usemaxOf
instead ofsort
, this can reduce time complexity from O(n*lg(n)) to O(n), so should be fastering by accident. Also removing an unused param
event
. These functions are located mostly atserver_script/xxx/unification/
These changes have been applied to my fork of E6/E6E for a long time, and they seems working pretty well