Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allowed ip range description fix for PGD #610

Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix: allowed ip range description fix for PGD #610

merged 5 commits into from
Nov 28, 2024

Conversation

wai-wong-edb
Copy link
Collaborator

No description provided.

edbamolvyavahare
edbamolvyavahare previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb
Merge branch 'main' into ww-allowed-ip-ranges-fix
10f4e40 
# Conflicts:
#	pkg/plan_modifier/data_group_custom_diff.go
edbamolvyavahare
edbamolvyavahare approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb wai-wong-edb merged commit 0b7badb into main Nov 28, 2024
7 checks passed
@wai-wong-edb wai-wong-edb deleted the ww-allowed-ip-ranges-fix branch November 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbamolvyavahare edbamolvyavahare edbamolvyavahare approved these changes

@vishalsawale9 vishalsawale9 Awaiting requested review from vishalsawale9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wai-wong-edb @edbamolvyavahare