v0.35 release candidate: GroPoint Modbus; Xbee & Digi WiFi fixes; Prep for batch transmission #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Modbus GPLP-8 sensor only, for now.
...replacing any vestiges from `YosemitechY4000.h`
from GroPointProfileGPLP8
Correctly initialize response code variable terminator.
Saves 750 bytes of flash as the buffer can be placed in .bss to be zero-initialized instead of .data.
Saves ~110 bytes of flash and substantial stack
Saves ~200 bytes of RAM and ~360 bytes of flash. The equations reproduce the tables previously found in the source code exactly. The reason for the values in the original tables is unknown.
The test for "15 seconds before the next logging interval" has been wrong for years, possibly since this code was written, with no apparent consequence. The behavior is additionally confusing to users deploying the devices and causes problems with logging as the modem won't get turned off for a long time. Remove it completely to solve the problems.
Use cleaner interface and common functions that avoid repeated snprintf and strlen usage to save ~2.5KB of flash and dozens of lines of code. Removes extra \r\n from HTTP requests as a side effect, which were against spec and caused spurious 400 Bad Request status messages from servers.
sendEveryX will be used in the future for data buffering functionality. Increase its width to an int to allow larger buffers when desired. Delete sendOffset completely as there is little reason for that particular functionality. The offset will be in effect set randomly using the time the datalogger initially powers on.
The C++ standard specifies that all objects in the same translation unit (i.e. source file) are constructed in order of declaration. Since this is the most common case when using Modular Sensors, the described case cannot occur.
Everything is working well!
Replace UNKNOWN w/ GPLPX for `gropointModel`, because it conflicted with YosemiTechModbus `UNKNOWN`
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Digi wifi s6b stability
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Vegapuls Implementation
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
SRGDamia1
reviewed
May 16, 2024
| return _modemName + F(" Sn ") + _modemSerialNumber + F(" HwVer ") + | ||
| _modemHwVersion + F(" FwVer ") + _modemFwVersion; | ||
| } | ||
|
|
There was a problem hiding this comment.
These need to be populated for all modems or moved just to the XBee where they are populated.
SRGDamia1
reviewed
May 16, 2024
| * version, and serial number fo the modem.. | ||
| */ | ||
| String getModemDevId(void); | ||
|
|
There was a problem hiding this comment.
Implement for all, or move to XBee
SRGDamia1
reviewed
May 16, 2024
| * Returned as a portion of the #getModemDevId(). | ||
| */ | ||
| String _modemSerialNumber; | ||
|
|
SRGDamia1
reviewed
May 16, 2024
src/modems/DigiXBeeWifi.cpp
Outdated
| gsmModem.exitCommand(); | ||
|
|
||
| ++updateModemMetadata_cnt; |
There was a problem hiding this comment.
Why always bump this and restart after 4?
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
|
Please add your changes to the change log! |
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR from
developtomasterprepares us for the next release, which includes these new features and improvements:This PR is required for our upcoming work on:
This PR could also optimally include:
@SRGDamia1 I think we want to begin reviewing and preparing this work for our next release. Let's also explore if it makes sense to release the completed work sooner so that we can have a clean
developbranch for upcoming work (i.e. #453 and #457).