Disable toggle WIP status button if user isn't logged-in

EpocDotFr · Apr 29, 2020 · a723632 · a723632
1 parent 653231e
commit a723632
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/html/options.html b/html/options.html
@@ -48,14 +48,17 @@
                 <div class="browser-style man"><input type="radio" required name="jira_ticket_link_label_type" value="icon" id="jira_ticket_link_label_type_icon" class="man"> <label for="jira_ticket_link_label_type_icon">An icon</label></div>
             </div>
         </div>
-        <div class="pts pbs row">
+        <div class="pts row">
             <div class="w40p txt-center browser-style">
                 <input type="checkbox" id="enable_button_to_toggle_wip_status">
             </div>
             <div>
                 <label for="enable_button_to_toggle_wip_status">Enable button allowing to toggle WIP status</label>
             </div>
         </div>
+        <div class="pbs pll">
+            <small class="txt-muted">This feature is automatically disabled if logged-out</small>
+        </div>
         <div class="txt-center pts pbs"><button type="submit" class="browser-style">Save preferences</button></div>
     </form>
 

diff --git a/js/content.js b/js/content.js
@@ -123,6 +123,7 @@
 
             this.baseUrl = location.protocol + '//' + location.host;
             this.baseApiUrl = this.baseUrl + '/api/v4/';
+            this.userAuthenticated = this.isUserAuthenticated();
             this.apiClient = new GitLabApiClient(this.baseApiUrl, this.getCsrfToken());
 
             let currentMergeRequestIds = this.getCurrentMergeRequestIds();
@@ -167,6 +168,13 @@
             return meta ? meta.getAttribute('content') : null;
         }
 
+        /**
+         * Determines if the current user is logged-in to GitLab.
+         */
+        isUserAuthenticated() {
+            return document.querySelector('.navbar-nav .header-user') ? true : false;
+        }
+
         /**
          * Gets all Merge Requests IDs that are currently displayed.
          */
@@ -199,7 +207,7 @@
                             self.attachClickEventToCopyMergeRequestInfoButtons();
                         }
 
-                        if (self.preferences.enable_button_to_toggle_wip_status) {
+                        if (self.userAuthenticated && self.preferences.enable_button_to_toggle_wip_status) {
                             self.attachClickEventToToggleWipStatusButtons();
                         }
                     } else {
@@ -275,7 +283,7 @@
                 // -----------------------------------------------
                 // Toggle WIP status button
 
-                if (this.preferences.enable_button_to_toggle_wip_status) {
+                if (this.userAuthenticated && this.preferences.enable_button_to_toggle_wip_status) {
                     let toggleWipStatusButton = '<button class="btn btn-secondary btn-md btn-default btn-transparent btn-clipboard has-tooltip gmrle-toggle-wip-status" title="Toggle WIP status" style="padding-left: 0">' +
                         '<i class="fa fa-wrench" aria-hidden="true"></i>' +
                     '</button> ';