Skip to content

Commit

Permalink
ci(release): fix jsonpath syntax for updating extra files (#10170)
Browse files Browse the repository at this point in the history
## Summary

- Use absolute path instead of relative as recommended in
<googleapis/release-please#2064 (comment)>
- Fix a syntax issue in the `jsonpath` to the extra files. The library
they use is [different than the
original](https://github.com/dchester/jsonpath?tab=readme-ov-file#other-minor-differences)
I've used in the past. Specifically:
> non-ascii non-word characters are no-longer valid in member identifier
names; use quoted subscript strings instead (e.g., `$['$']` instead of
`$.$`)
  • Loading branch information
benelan authored Aug 28, 2024
1 parent c8ecabb commit 68bf821
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,33 +11,33 @@
"readme.md",
{
"type": "json",
"path": "../../examples/components/preact/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/preact/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
},
{
"type": "json",
"path": "../../examples/components/rollup/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/rollup/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
},
{
"type": "json",
"path": "../../examples/components/vite/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/vite/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
},
{
"type": "json",
"path": "../../examples/components/vue/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/vue/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
},
{
"type": "json",
"path": "../../examples/components/web-dev-server/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/web-dev-server/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
},
{
"type": "json",
"path": "../../examples/components/webpack/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components"
"path": "/examples/components/webpack/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components']"
}
]
},
Expand All @@ -46,8 +46,8 @@
"extra-files": [
{
"type": "json",
"path": "../../examples/components/react/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components-react"
"path": "/examples/components/react/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components-react']"
}
]
},
Expand All @@ -56,8 +56,8 @@
"extra-files": [
{
"type": "json",
"path": "../../examples/components/angular/package.json",
"jsonpath": "$.dependencies.@esri/calcite-components-angular"
"path": "/examples/components/angular/package.json",
"jsonpath": "$.dependencies['@esri/calcite-components-angular']"
}
]
},
Expand Down

0 comments on commit 68bf821

Please sign in to comment.