Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linting): set up no-restricted-syntax rule to ensure all E2E test pages are created initially #6908

Closed
wants to merge 4 commits into from
Closed

chore(linting): set up no-restricted-syntax rule to ensure all E2E test pages are created initially #6908

wants to merge 4 commits into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented May 3, 2023 •
edited
Loading

Related Issue: #4844

Summary

This PR uses no-restricted-syntax rule to enforce a single way of initializing tests for both consistency and test stability.

Additionally, this also updates tests to be consistent and also uses the html tagged template for consistent formatting.

@jcfranco jcfranco requested a review from a team as a code owner May 3, 2023 03:16
driskull
driskull approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label May 3, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label May 11, 2023
@jcfranco jcfranco marked this pull request as draft June 20, 2023 23:55
@jcfranco
Copy link
Member Author

Set to draft to update to latest changes and to look into some unstable tests that started showing up in this PR. 🙃

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 21, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 28, 2023
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 3, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:17
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 21, 2024
@jcfranco
Copy link
Member Author

Closing. Will revisit after #10310 if needed.

@jcfranco jcfranco closed this Sep 15, 2024
@jcfranco jcfranco deleted the jcfranco/enforce-consistent-e2e-test-page-creation branch September 15, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan benelan will be requested when the pull request is marked ready for review benelan is a code owner

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull