Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to solve https://github.com/Esri/calcite-react/issues/380 #401

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pshirodkar20
Copy link

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@pshirodkar20 pshirodkar20 changed the title Changed inputValue to selectedValue in DownShift(Search)to solve https://github.com/Esri/calcite-react/issues/380 Changes to solve https://github.com/Esri/calcite-react/issues/380 Aug 27, 2020
@codylawson
Copy link
Contributor

Hey @pshirodkar20 this solution seems to break the clear text button. Can you think of a way to clear out the downshift input when that button is pressed?

@pshirodkar20
Copy link
Author

@codylawson Okay, let me take a look. Is there something you could suggest that I should use instead of inputValue attribute in the DownShift component? I haven't worked with DownShift before so maybe I am missing on something you know. Thanks.

@codylawson
Copy link
Contributor

@pshirodkar20 I've looked into it quite a bit and hadn't found any simple fixes which is why I wasn't able to resolve the bug already. Most of what I'd found made it seem we need to rewrite the Downshift components using the latest version patterns. There were originally problems with the cursor position in Downshift at an early version, but the fix was checked in well before our current version in calcite react so there's something else going on.

If you can figure out a clean way to reset the inputValue when the button is clicked without having to rewrite the whole thing, that would be ideal haha. Otherwise I'll have to come back to it when I have a little more time to rewrite it.

Sorry I can't be of more help right now 😞

@pshirodkar20
Copy link
Author

@codylawson Oh okay, let me see if I can fix the clear input field. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants