Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update export of package version #187

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

tstackhouse
Copy link
Contributor

The way the export of version is structured when this package is imported, the following build error can occur:

./node_modules/esri-leaflet-vector/src/EsriLeafletVector.js:1:0-53 - Error: Should not import the named export 'version' (reexported as 'VERSION') from default-exporting module (only default export is available soon)

Specifically I'm seeing this in an Nx + Angular 15 monorepo environment when building in SSR, but I'm certain others are seeing similar issues caused by this export syntax.

@gavinr-maps
Copy link
Contributor

gavinr-maps commented Aug 7, 2023

Thank you very much for this PR. Yes I think this is an issue across the esri-leaflet-* packages- we fixed it in Esri Leaflet here: Esri/esri-leaflet#1273

@gavinr-maps gavinr-maps requested review from gavinr and gavinr-maps and removed request for gavinr August 7, 2023 18:01
consistent pattern with Esri Leaflet
@gavinr-maps gavinr-maps merged commit bbc8d12 into Esri:master Aug 7, 2023
9 checks passed
@gavinr-maps
Copy link
Contributor

This was released in v4.2.0.

@tstackhouse tstackhouse deleted the version-export-fix branch October 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants