updated maplibre-gl dependency to v3.3.1, passing all tests #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickarlt
requested changes
Oct 6, 2023
There was a problem hiding this comment.
@gavinr this looks good be since there are no direct breaking changes for us I wonder if we should make this peer dependency something like ^2.0.0 || ^3.0.0 so show that we can support v2 OR v3 of MapLibre right now.
|
@patrickarlt sounds good. I made that change. So this would not be a breaking change for esri-leaflet-vector then, correct? So we can release this under v4.2.1 ? |
gavinr-maps
approved these changes
Oct 9, 2023
|
This was released in v4.2.1. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the dependency to v3.3.1, which happens to be the latest and also ran the tests. The results are attached below. Please let me know if I'm missing anything else since this is my very first time contributing to an open-source repo! :)
Test results after upgrading the maplibre-gl dependency to v3.3.1:
