Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rtl support and example #206 #207

Merged
merged 1 commit into from
Oct 20, 2023
Merged

add rtl support and example #206 #207

merged 1 commit into from
Oct 20, 2023

Conversation

gowin20
Copy link
Contributor

@gowin20 gowin20 commented Oct 19, 2023

  • Adds support for RTL language labels by exposing the maplibre setRTLTextPlugin method.

  • Adds an example showing how to use it:

// Support RTL languages such as Arabic and Hebrew
L.esri.Vector.setRTLTextPlugin('https://unpkg.com/@mapbox/mapbox-gl-rtl-text@0.2.3/mapbox-gl-rtl-text.js');

#206/#204

Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like adding this function to our library that calls setRTLTextPlugin on maplibregl is the best way to do this. Looks good!

@gavinr-maps gavinr-maps merged commit 770bd46 into master Oct 20, 2023
18 checks passed
@gavinr-maps gavinr-maps deleted the go-rtl-support branch October 20, 2023 18:38
@gavinr-maps
Copy link
Contributor

Released in v4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants