Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference GL Map resize function in place of undefined reference #211

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Reference GL Map resize function in place of undefined reference #211

merged 1 commit into from
Dec 1, 2023

Conversation

sheeley820
Copy link
Contributor

Related to Issue #210, where there is a warning about an undefined listener.

Changes:

  • Replace this undefined reference with a pointer to MapGL's resize function.
  • Two small comment text changes

@sheeley820 sheeley820 mentioned this pull request Nov 15, 2023
Closed
@patrickarlt
Copy link
Contributor

@gavinr can you review and merge this?

gavinr-maps
gavinr-maps approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@gavinr-maps gavinr-maps merged commit 2e47516 into Esri:master Dec 1, 2023
9 checks passed
@gavinr-maps
Copy link
Contributor

Released in v4.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinr-maps gavinr-maps gavinr-maps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheeley820 @patrickarlt @gavinr-maps