Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add worldview and places params #214

Merged
merged 6 commits into from
Dec 5, 2023
Merged

add worldview and places params #214

merged 6 commits into from
Dec 5, 2023

Conversation

gowin20
Copy link
Contributor

@gowin20 gowin20 commented Nov 17, 2023

connected issue: #213

This PR currently adds support for the worldview parameter. I also added support for the places parameter, but requesting places through esri leaflet is currently resulting in the following styling error:

image

This error will need to be investigated further. I am sure how to fix this off the top of my head.

@gavinr-maps
Copy link
Contributor

The #fffffr issue is covered #212 - please see the discussion there.

@gowin20
Copy link
Contributor Author

gowin20 commented Dec 1, 2023

the arcgis/navigation style is working again so this PR should be ready for review now @gavinr-maps

Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and works well! Just a few optional suggestions here:

examples/worldview.html Outdated Show resolved Hide resolved
src/Util.js Show resolved Hide resolved
@gowin20 gowin20 changed the title add worldview param and places wip add worldview and places params Dec 4, 2023
gowin20 and others added 3 commits December 4, 2023 12:41
Co-authored-by: Gavin Rehkemper <grehkemper@esri.com>
@gavinr-maps gavinr-maps merged commit 299f3f3 into master Dec 5, 2023
18 checks passed
@gavinr-maps gavinr-maps deleted the go-v2-params branch December 5, 2023 13:33
@gavinr-maps
Copy link
Contributor

This was released in v4.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants