fix(hub-common): add trackCacheUpdate by default when polling download API #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansth1010
changed the title
esri-dcdev-2
pushed a commit
that referenced
this pull request
Sep 26, 2024
## @esri/hub-common [14.196.1](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.196.0...@esri/hub-common@14.196.1) (2024-09-26) ### Bug Fixes * **hub-common:** add trackCacheUpdate by default when polling download API ([#1670](#1670)) ([0a701c0](0a701c0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When there is no cache for a dataset whose service have editor tracking disabled and download is requested. Cache generation process is completed, a notice that "cache may be outdated" is present. This might be confusing to the user because user just finished generated a cache. The notice is not expected immediately after cache generation.
This fixes the bug by pending
trackCacheUpdatequery params which contains the response to hide notice when download job is complete.Description:
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.