feat: events processFilters support occurrence && group to sharedToGroup #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benstoltz
changed the title
juliannemarik
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
These changes/additions all look good to me, but I defer to @rweber-esri for a formal approval.
packages/common/test/search/_internal/hubEventsHelpers/processFilters.test.ts
Outdated
Show resolved
Hide resolved
esri-dcdev-2
pushed a commit
that referenced
this pull request
Oct 11, 2024
# @esri/hub-common [14.212.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.211.0...@esri/hub-common@14.212.0) (2024-10-11) ### Features * events processFilters support occurrence && group to sharedToGroup ([#1683](#1683)) ([44bb6f2](44bb6f2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.