Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.3 #206

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add support for PHP 8.3 #206

merged 1 commit into from
Apr 9, 2024

Conversation

fredden
Copy link
Collaborator

@fredden fredden commented Mar 22, 2024

Fixes #205

@fredden
Copy link
Collaborator Author

fredden commented Mar 22, 2024

I expect the tests to pass here after extdn/github-actions-m2#112 gets merged in and Magento 2.4.7 is released.

@peterjaap
Copy link

@Ethan3600 could you re-run the tests and if they succeed, merge this MR?

@fredden
Copy link
Collaborator Author

fredden commented Mar 29, 2024

@peterjaap I've re-run this job: https://github.com/Ethan3600/magento2-CronjobManager/actions/runs/8394576024/job/23246115732?pr=206
It's still failing because Magento v2.4.7 hasn't been released yet. According to https://devdocs.magento.com/release/, it should be out in ~12 days. I've put a note in my calendar to come back here and re-run the tests then.

@fredden fredden mentioned this pull request Mar 29, 2024
@peterjaap
Copy link

@fredden 2.4.7 is released :)

@fredden
Copy link
Collaborator Author

fredden commented Apr 9, 2024

Magento v2.4.7 has been released. I have re-run all the tests here. Some tests are failing, but nothing seems related to PHP 8.3. I'll merge this in now (and tag a release), and review the test failures separately.

@fredden fredden merged commit 6fee38a into 2.x Apr 9, 2024
14 of 20 checks passed
@fredden fredden deleted the feature/php-8.3-support branch April 9, 2024 13:44
@peterjaap
Copy link

Awesome, thanks for the swift response! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants