Rust frontend electric boogaloo #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the .envrc for probe_frontend to automatically run make on libprobe, as well as export the __PROBE_LIB environment variable so that the frontend can find the libprobe.so
Co-authored-by: Sam Grayson <sam@samgrayson.me>
Removes a lot of details that are usually abstracted by libraries when printing for humans. In contrast with some of the code review comments I left mtime and errno field because I feel those are useful for human readers; even if all a human is likley to do with errno is "was it zero?"
This commit addresses serveral points raised durring the last code-review (and a few that weren't): - Restructured arena.rs to read top-down. - Refactored child process code to use std::process instead of subprocess crate. - Cleaned up arena pointer resolition to use less unsafe code. - [INFO] Better log messages.
Co-authored-by: Sam Grayson <sam@samgrayson.me>
the structs now get converted to camel case at the rust level instead of the python level meaning python doesn't have to do any type name translation. Also strips out redundant field prefixes from the rust structs (which also solves the issue for python).
building the probe cli with `cargo build` inside the devShell will still produce a dynamically linked binary, but building with `nix build .#probe-cli` should produce a statically linked binary
|
Closed in favor of charmoniumQ#36 and charmoniumQ#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to integrate your stuff with my stuff which involves a few changes in
prov_ops.hand better glue code. I saw the note that "this might have to be merged into the top-level flake" and made it so. Also I thinkprov_ops.hmakes sense as its own Nix package that libprobe and probe_* depend on.I noticed this has lots of unrelated changes from
main. I'm going to try doing a rebase instead of a merge or something like that.