-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terrain-Aware Immersed Forcing Method #1115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbkuhn
reviewed
Oct 8, 2024
mbkuhn
reviewed
Oct 8, 2024
mbkuhn
reviewed
Oct 8, 2024
Can you update the branch please? Looks like there are conflicts. |
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
amr-wind/equation_systems/temperature/source_terms/DragTempForcing.cpp
Outdated
Show resolved
Hide resolved
marchdf
reviewed
Oct 8, 2024
amr-wind/equation_systems/temperature/source_terms/DragTempForcing.cpp
Outdated
Show resolved
Hide resolved
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
amr-wind/equation_systems/temperature/source_terms/DragTempForcing.cpp
Outdated
Show resolved
Hide resolved
marchdf
reviewed
Oct 8, 2024
amr-wind/equation_systems/temperature/source_terms/DragTempForcing.cpp
Outdated
Show resolved
Hide resolved
marchdf
reviewed
Oct 8, 2024
amr-wind/equation_systems/temperature/source_terms/DragTempForcing.cpp
Outdated
Show resolved
Hide resolved
marchdf
reviewed
Oct 8, 2024
marchdf
reviewed
Oct 8, 2024
marchdf
approved these changes
Oct 8, 2024
moprak-nrel
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR introduces an immersed forcing method for representing terrain within AMR-Wind. The terrain is generated outside amr-wind and this method does not rely on the existing immersed boundary method. The terrain runs are performed in steps:
The method can also be used to run cases without terrain such as an array of bluff bodies. The user has to create a XYZ file with the relevant information to do perform these simulations. The user can also use the stl2XYZ.py in tools/terrain folder to convert a STL file to XYZ file for AMR-Wind. It is recommended to have a smooth boundary near the inflow and outflow to reduce the number of iterations of the nodal and Mac projections.
The terrain modules have been designed to run with the Kosovic turbulence model. To use other turbulence models, the terrainBlanking information should be used to set the turbulent viscosity to zero in the solid region. It is also possible to specify a roughness file to include non-uniform roughness in the simulations.
The method is first-order accurate.
Reference Paper: https://agupubs.onlinelibrary.wiley.com/doi/full/10.1029/2020MS002141
Implemented Code: FastEddy for urban microclimate without log-law. handling
Not included in the current PR:
Pull request type
PR is almost ready to be reviewed.
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running: