fix: set default value for db_instance_class and db_backup_retention (#…

…276) Co-authored-by: janli <janli@expediagroup.com>
ExpediaGroup · Sep 11, 2024 · 578970e · 578970e
1 parent 2460749
commit 578970e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.3.7] - 2024-09-10
+### Fixed
+- Set `db_instance_class` default to `db.t4g.medium`.
+- Set `db_backup_retention` default to `7`.
+
 ## [7.3.6] - 2024-09-10
 ### Added
 - Added new variable `external_database_host_readonly` to handle externel mysql readonly host.

diff --git a/VARIABLES.md b/VARIABLES.md
@@ -28,12 +28,12 @@
 | apiary\_common\_producer\_iamroles                                | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets.                                                                                                                        | `list(string)`           | `[]`                                                                                                                                                                                                                                                                                           |    no    |
 | dashboard\_namespace                                      | k8s namespace to deploy grafana dashboard.                                                                                                                                                                           | `string`                 | `"monitoring"`                                                                                                                                                                                                                                                                                 |    no    |
 | db\_apply\_immediately                                    | Specifies whether any cluster modifications are applied immediately, or during the next maintenance window.                                                                                                          | `bool`                   | `false`                                                                                                                                                                                                                                                                                        |    no    |
-| db\_backup\_retention                                     | The number of days to retain backups for the RDS Metastore DB.                                                                                                                                                       | `string`                 | n/a                                                                                                                                                                                                                                                                                            |   yes    |
+| db\_backup\_retention                                     | The number of days to retain backups for the RDS Metastore DB.                                                                                                                                                       | `string`                 | `"7"`                                                                                                                                                                                                                                                                                            |   yes    |
 | db\_backup\_window                                        | Preferred backup window for the RDS Metastore DB in UTC.                                                                                                                                                             | `string`                 | `"02:00-03:00"`                                                                                                                                                                                                                                                                                |    no    |
 | db\_copy\_tags\_to\_snapshot                              | Copy all Cluster tags to snapshots.                                                                                                                                                                                  | `bool`                   | `true`                                                                                                                                                                                                                                                                                         |    no    |
 | db\_enable\_performance\_insights                         | Enable RDS Performance Insights                                                                                                                                                                                      | `bool`                   | `false`                                                                                                                                                                                                                                                                                        |    no    |
 | db\_enhanced\_monitoring\_interval                        | RDS monitoring interval (in seconds) for enhanced monitoring.  Valid values are 0, 1, 5, 10, 15, 30, 60. Default is 0.                                                                                               | `number`                 | `0`                                                                                                                                                                                                                                                                                            |    no    |
-| db\_instance\_class                                       | Instance type for the RDS Metastore DB.                                                                                                                                                                              | `string`                 | n/a                                                                                                                                                                                                                                                                                            |   yes    |
+| db\_instance\_class                                       | Instance type for the RDS Metastore DB.                                                                                                                                                                              | `string`                 | `"db.t4g.medium"`                                                                                                                                                                                                                                                                                            |   yes    |
 | db\_instance\_count                                       | Desired count of database cluster instances.                                                                                                                                                                         | `string`                 | `"2"`                                                                                                                                                                                                                                                                                          |    no    |
 | db\_maintenance\_window                                   | Preferred maintenance window for the RDS Metastore DB in UTC.                                                                                                                                                        | `string`                 | `"wed:03:00-wed:04:00"`                                                                                                                                                                                                                                                                        |    no    |
 | db\_master\_username                                      | Aurora cluster MySQL master user name.                                                                                                                                                                               | `string`                 | `"apiary"`                                                                                                                                                                                                                                                                                     |    no    |

diff --git a/variables.tf b/variables.tf
@@ -249,6 +249,7 @@ variable "db_ro_secret_name" {
 variable "db_instance_class" {
   description = "Instance type for the RDS Metastore DB."
   type        = string
+  default     = "db.t4g.medium"
 }
 
 variable "db_instance_count" {
@@ -260,6 +261,7 @@ variable "db_instance_count" {
 variable "db_backup_retention" {
   description = "The number of days to retain backups for the RDS Metastore DB."
   type        = string
+  default     = "7"
 }
 
 variable "db_apply_immediately" {