Add S3 versioning to managed schemas #291
Conversation
variables.tf
Outdated
| variable "s3_versioning_max_versions_retained" { | ||
| description = "Number of noncurrent versions Amazon S3 will retain. Must be a non-zero positive integer. Bucket need to have versioning enabled." | ||
| type = number | ||
| default = 3 |
There was a problem hiding this comment.
This should be defaulted off... we don't want to force keeping a number of versions, we want all the versions to be deleted after 7 days by default. If both are set, then it will keep the max versions regardless of the days, which means we will end up keeping some of the deleted data forever (at least this is what I believe I tested and saw that it always retained up to the max versions).
There was a problem hiding this comment.
I added both options, only days, or days and max_versions.
My idea was that if maybe there is a bucket that creates many versions a day, we could reduce costs setting max to 1. Not sure if it could happen, I can delete that part anyway and add it when needed.
s3.tf
Outdated
| # Rule enabled when expiration max days is set | ||
| rule { | ||
| id = "expire-noncurrent-versions-days" | ||
| status = lookup(each.value, "s3_versioning_expiration_days", "") != "" && lookup(each.value, "s3_versioning_max_versions_retained", "") == "" ? "Enabled" : "Disabled" |
There was a problem hiding this comment.
This doesn't take the default value into account at all does it, the default is ""? So it will only be enabled or disabled depending on what is in the map, and the default value in the var is ignored here. But then the default value IS pulled in in the actual days or versions setting below. I'm not sure I understand... if we override it in the map, then the default will be ignored in both places. If we don't override it in the map, then it will be disabled. There is no case in which the default value will be used?
I guess in the second rule for max versions and days it could be used but only for setting the expiration_days, which only can happen if expiration_days is not set in the map, then it will use the default for it?
I wonder if it is simpler to just leave out the max versions rule completely. I'm not sure we have a case for it anyway. It's an option in the API but I don't think we want to use it.
There was a problem hiding this comment.
Okay, let's do it in that case only days
| status = lookup(each.value, "s3_versioning_expiration_days", "") != "" ? "Enabled" : "Disabled" | ||
|
|
||
| noncurrent_version_expiration { | ||
| noncurrent_days = tonumber(lookup(each.value, "s3_versioning_expiration_days", var.s3_versioning_expiration_days)) |
There was a problem hiding this comment.
Question, should we only configure the version expiration? Or should we also configure the max version retain , like 1,2,3 ? If only expiration configured, all older version will be deleted after the days meet.
There was a problem hiding this comment.
Replied privately, conclusion was to start only with days.
Hive databases backed by S3 can now have versioning enabled.