Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(generator): use new willBuildSchema/didBuildSchema #1817

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

Cleanup schema generation hooks to have proper BEFORE and AFTER generation hooks.

Changes:

  • Rename existing willBuildSchema hook to didBuildSchema hook to indicate that it executes AFTER generating the schema.
  • Add new willBuildSchema hook that executes BEFORE any schema generation logic kicks in

Cleanup schema generation hooks to have proper BEFORE and AFTER generation hooks.

Changes:
* Rename existing `willBuildSchema` hook to `didBuildSchema` hook to indicate that it executes AFTER generating the schema.
* Add new `willBuildSchema` hook that executes BEFORE any schema generation logic kicks in
@dariuszkuc dariuszkuc added changes: major Changes require a major version module: generator Issue affects the schema generator and federation code labels Jul 27, 2023
@dariuszkuc dariuszkuc enabled auto-merge (squash) July 27, 2023 23:56
@dariuszkuc dariuszkuc merged commit 31c4e12 into ExpediaGroup:master Aug 2, 2023
10 checks passed
@dariuszkuc dariuszkuc deleted the schema_hooks branch August 2, 2023 18:05
.run {
config.hooks.willBuildSchema(this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version module: generator Issue affects the schema generator and federation code
Development

Successfully merging this pull request may close these issues.

2 participants