Merge pull request #36 from Expensify/Rory-DestructuringAssignment

Ban destructuring of props or state
Expensify · Nov 5, 2021 · 5ec12a8 · 5ec12a8
2 parents 211e217 + 7554ad0
commit 5ec12a8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-expensify",
-  "version": "2.0.17",
+  "version": "2.0.18",
   "description": "Expensify's ESLint configuration following our style guide",
   "main": "index.js",
   "repository": {

diff --git a/rules/react.js b/rules/react.js
@@ -19,10 +19,7 @@ module.exports = {
         'react/forbid-prop-types': 'error',
         'react/no-string-refs': 'error',
         'react/jsx-filename-extension': [1, {extensions: ['.js']}],
-
-        // Do not warn or error for destructuring
-        // See: https://github.com/Expensify/Style-Guide/blob/master/javascript.md#destructuring
-        'react/destructuring-assignment': 'off',
+        'react/destructuring-assignment': ['error', 'never'],
 
         // New versions of react are removing some methods, and those methods have been prefixed with "UNSAFE_" for now.
         // We need to prevent more usages of these methods and their aliases from being added